wangpengfei
2023-06-02 064c0874e5fd041c4641ef873d1bf72ac98a184d
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
/*
Copyright 2014 The Kubernetes Authors.
 
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
 
    http://www.apache.org/licenses/LICENSE-2.0
 
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
 
package transport
 
import (
    "net/http"
    "net/url"
    "reflect"
    "strings"
    "testing"
)
 
type testRoundTripper struct {
    Request  *http.Request
    Response *http.Response
    Err      error
}
 
func (rt *testRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) {
    rt.Request = req
    return rt.Response, rt.Err
}
 
func TestMaskValue(t *testing.T) {
    tcs := []struct {
        key      string
        value    string
        expected string
    }{
        {
            key:      "Authorization",
            value:    "Basic YWxhZGRpbjpvcGVuc2VzYW1l",
            expected: "Basic <masked>",
        },
        {
            key:      "Authorization",
            value:    "basic",
            expected: "basic",
        },
        {
            key:      "Authorization",
            value:    "Basic",
            expected: "Basic",
        },
        {
            key:      "Authorization",
            value:    "Bearer cn389ncoiwuencr",
            expected: "Bearer <masked>",
        },
        {
            key:      "Authorization",
            value:    "Bearer",
            expected: "Bearer",
        },
        {
            key:      "Authorization",
            value:    "bearer",
            expected: "bearer",
        },
        {
            key:      "Authorization",
            value:    "bearer ",
            expected: "bearer",
        },
        {
            key:      "Authorization",
            value:    "Negotiate cn389ncoiwuencr",
            expected: "Negotiate <masked>",
        },
        {
            key:      "ABC",
            value:    "Negotiate cn389ncoiwuencr",
            expected: "Negotiate cn389ncoiwuencr",
        },
        {
            key:      "Authorization",
            value:    "Negotiate",
            expected: "Negotiate",
        },
        {
            key:      "Authorization",
            value:    "Negotiate ",
            expected: "Negotiate",
        },
        {
            key:      "Authorization",
            value:    "negotiate",
            expected: "negotiate",
        },
        {
            key:      "Authorization",
            value:    "abc cn389ncoiwuencr",
            expected: "<masked>",
        },
        {
            key:      "Authorization",
            value:    "",
            expected: "",
        },
    }
    for _, tc := range tcs {
        maskedValue := maskValue(tc.key, tc.value)
        if tc.expected != maskedValue {
            t.Errorf("unexpected value %s, given %s.", maskedValue, tc.value)
        }
    }
}
 
func TestBearerAuthRoundTripper(t *testing.T) {
    rt := &testRoundTripper{}
    req := &http.Request{}
    NewBearerAuthRoundTripper("test", rt).RoundTrip(req)
    if rt.Request == nil {
        t.Fatalf("unexpected nil request: %v", rt)
    }
    if rt.Request == req {
        t.Fatalf("round tripper should have copied request object: %#v", rt.Request)
    }
    if rt.Request.Header.Get("Authorization") != "Bearer test" {
        t.Errorf("unexpected authorization header: %#v", rt.Request)
    }
}
 
func TestBasicAuthRoundTripper(t *testing.T) {
    for n, tc := range map[string]struct {
        user string
        pass string
    }{
        "basic":   {user: "user", pass: "pass"},
        "no pass": {user: "user"},
    } {
        rt := &testRoundTripper{}
        req := &http.Request{}
        NewBasicAuthRoundTripper(tc.user, tc.pass, rt).RoundTrip(req)
        if rt.Request == nil {
            t.Fatalf("%s: unexpected nil request: %v", n, rt)
        }
        if rt.Request == req {
            t.Fatalf("%s: round tripper should have copied request object: %#v", n, rt.Request)
        }
        if user, pass, found := rt.Request.BasicAuth(); !found || user != tc.user || pass != tc.pass {
            t.Errorf("%s: unexpected authorization header: %#v", n, rt.Request)
        }
    }
}
 
func TestUserAgentRoundTripper(t *testing.T) {
    rt := &testRoundTripper{}
    req := &http.Request{
        Header: make(http.Header),
    }
    req.Header.Set("User-Agent", "other")
    NewUserAgentRoundTripper("test", rt).RoundTrip(req)
    if rt.Request == nil {
        t.Fatalf("unexpected nil request: %v", rt)
    }
    if rt.Request != req {
        t.Fatalf("round tripper should not have copied request object: %#v", rt.Request)
    }
    if rt.Request.Header.Get("User-Agent") != "other" {
        t.Errorf("unexpected user agent header: %#v", rt.Request)
    }
 
    req = &http.Request{}
    NewUserAgentRoundTripper("test", rt).RoundTrip(req)
    if rt.Request == nil {
        t.Fatalf("unexpected nil request: %v", rt)
    }
    if rt.Request == req {
        t.Fatalf("round tripper should have copied request object: %#v", rt.Request)
    }
    if rt.Request.Header.Get("User-Agent") != "test" {
        t.Errorf("unexpected user agent header: %#v", rt.Request)
    }
}
 
func TestImpersonationRoundTripper(t *testing.T) {
    tcs := []struct {
        name                string
        impersonationConfig ImpersonationConfig
        expected            map[string][]string
    }{
        {
            name: "all",
            impersonationConfig: ImpersonationConfig{
                UserName: "user",
                Groups:   []string{"one", "two"},
                Extra: map[string][]string{
                    "first":  {"A", "a"},
                    "second": {"B", "b"},
                },
            },
            expected: map[string][]string{
                ImpersonateUserHeader:                       {"user"},
                ImpersonateGroupHeader:                      {"one", "two"},
                ImpersonateUserExtraHeaderPrefix + "First":  {"A", "a"},
                ImpersonateUserExtraHeaderPrefix + "Second": {"B", "b"},
            },
        },
        {
            name: "escape handling",
            impersonationConfig: ImpersonationConfig{
                UserName: "user",
                Extra: map[string][]string{
                    "test.example.com/thing.thing": {"A", "a"},
                },
            },
            expected: map[string][]string{
                ImpersonateUserHeader: {"user"},
                ImpersonateUserExtraHeaderPrefix + `Test.example.com%2fthing.thing`: {"A", "a"},
            },
        },
        {
            name: "double escape handling",
            impersonationConfig: ImpersonationConfig{
                UserName: "user",
                Extra: map[string][]string{
                    "test.example.com/thing.thing%20another.thing": {"A", "a"},
                },
            },
            expected: map[string][]string{
                ImpersonateUserHeader: {"user"},
                ImpersonateUserExtraHeaderPrefix + `Test.example.com%2fthing.thing%2520another.thing`: {"A", "a"},
            },
        },
    }
 
    for _, tc := range tcs {
        rt := &testRoundTripper{}
        req := &http.Request{
            Header: make(http.Header),
        }
        NewImpersonatingRoundTripper(tc.impersonationConfig, rt).RoundTrip(req)
 
        for k, v := range rt.Request.Header {
            expected, ok := tc.expected[k]
            if !ok {
                t.Errorf("%v missing %v=%v", tc.name, k, v)
                continue
            }
            if !reflect.DeepEqual(expected, v) {
                t.Errorf("%v expected %v: %v, got %v", tc.name, k, expected, v)
            }
        }
        for k, v := range tc.expected {
            expected, ok := rt.Request.Header[k]
            if !ok {
                t.Errorf("%v missing %v=%v", tc.name, k, v)
                continue
            }
            if !reflect.DeepEqual(expected, v) {
                t.Errorf("%v expected %v: %v, got %v", tc.name, k, expected, v)
            }
        }
    }
}
 
func TestAuthProxyRoundTripper(t *testing.T) {
    for n, tc := range map[string]struct {
        username      string
        groups        []string
        extra         map[string][]string
        expectedExtra map[string][]string
    }{
        "allfields": {
            username: "user",
            groups:   []string{"groupA", "groupB"},
            extra: map[string][]string{
                "one": {"alpha", "bravo"},
                "two": {"charlie", "delta"},
            },
            expectedExtra: map[string][]string{
                "one": {"alpha", "bravo"},
                "two": {"charlie", "delta"},
            },
        },
        "escaped extra": {
            username: "user",
            groups:   []string{"groupA", "groupB"},
            extra: map[string][]string{
                "one":             {"alpha", "bravo"},
                "example.com/two": {"charlie", "delta"},
            },
            expectedExtra: map[string][]string{
                "one":               {"alpha", "bravo"},
                "example.com%2ftwo": {"charlie", "delta"},
            },
        },
        "double escaped extra": {
            username: "user",
            groups:   []string{"groupA", "groupB"},
            extra: map[string][]string{
                "one":                     {"alpha", "bravo"},
                "example.com/two%20three": {"charlie", "delta"},
            },
            expectedExtra: map[string][]string{
                "one":                         {"alpha", "bravo"},
                "example.com%2ftwo%2520three": {"charlie", "delta"},
            },
        },
    } {
        rt := &testRoundTripper{}
        req := &http.Request{}
        NewAuthProxyRoundTripper(tc.username, tc.groups, tc.extra, rt).RoundTrip(req)
        if rt.Request == nil {
            t.Errorf("%s: unexpected nil request: %v", n, rt)
            continue
        }
        if rt.Request == req {
            t.Errorf("%s: round tripper should have copied request object: %#v", n, rt.Request)
            continue
        }
 
        actualUsernames, ok := rt.Request.Header["X-Remote-User"]
        if !ok {
            t.Errorf("%s missing value", n)
            continue
        }
        if e, a := []string{tc.username}, actualUsernames; !reflect.DeepEqual(e, a) {
            t.Errorf("%s expected %v, got %v", n, e, a)
            continue
        }
        actualGroups, ok := rt.Request.Header["X-Remote-Group"]
        if !ok {
            t.Errorf("%s missing value", n)
            continue
        }
        if e, a := tc.groups, actualGroups; !reflect.DeepEqual(e, a) {
            t.Errorf("%s expected %v, got %v", n, e, a)
            continue
        }
 
        actualExtra := map[string][]string{}
        for key, values := range rt.Request.Header {
            if strings.HasPrefix(strings.ToLower(key), strings.ToLower("X-Remote-Extra-")) {
                extraKey := strings.ToLower(key[len("X-Remote-Extra-"):])
                actualExtra[extraKey] = append(actualExtra[key], values...)
            }
        }
        if e, a := tc.expectedExtra, actualExtra; !reflect.DeepEqual(e, a) {
            t.Errorf("%s expected %v, got %v", n, e, a)
            continue
        }
    }
}
 
// TestHeaderEscapeRoundTrip tests to see if foo == url.PathUnescape(headerEscape(foo))
// This behavior is important for client -> API server transmission of extra values.
func TestHeaderEscapeRoundTrip(t *testing.T) {
    t.Parallel()
    testCases := []struct {
        name string
        key  string
    }{
        {
            name: "alpha",
            key:  "alphabetical",
        },
        {
            name: "alphanumeric",
            key:  "alph4num3r1c",
        },
        {
            name: "percent encoded",
            key:  "percent%20encoded",
        },
        {
            name: "almost percent encoded",
            key:  "almost%zzpercent%xxencoded",
        },
        {
            name: "illegal char & percent encoding",
            key:  "example.com/percent%20encoded",
        },
        {
            name: "weird unicode stuff",
            key:  "example.com/ᛒᚥᛏᛖᚥᚢとロビン",
        },
        {
            name: "header legal chars",
            key:  "abc123!#$+.-_*\\^`~|'",
        },
        {
            name: "legal path, illegal header",
            key:  "@=:",
        },
    }
    for _, tc := range testCases {
        t.Run(tc.name, func(t *testing.T) {
            escaped := headerKeyEscape(tc.key)
            unescaped, err := url.PathUnescape(escaped)
            if err != nil {
                t.Fatalf("url.PathUnescape(%q) returned error: %v", escaped, err)
            }
            if tc.key != unescaped {
                t.Errorf("url.PathUnescape(headerKeyEscape(%q)) returned %q, wanted %q", tc.key, unescaped, tc.key)
            }
        })
    }
}