From 5ef0753a827fb33daad7d8ae7f96385c088f2692 Mon Sep 17 00:00:00 2001
From: zhangqian <zhangqian@123.com>
Date: 星期五, 08 九月 2023 19:09:59 +0800
Subject: [PATCH] fix

---
 api/v1/task.go |   32 ++++++++++++++------------------
 1 files changed, 14 insertions(+), 18 deletions(-)

diff --git a/api/v1/task.go b/api/v1/task.go
index cfd6ce1..7fb3b50 100644
--- a/api/v1/task.go
+++ b/api/v1/task.go
@@ -11,7 +11,6 @@
 	"apsClient/pkg/convertx"
 	"apsClient/pkg/ecode"
 	"apsClient/pkg/logx"
-	"apsClient/pkg/plc"
 	"apsClient/service"
 	"apsClient/service/plc_address"
 	"errors"
@@ -199,8 +198,8 @@
 
 	processModel, err := taskService.GetProcessParams(procedure, order)
 	if err != nil || processModel == nil || processModel.ParamsMap == nil {
-		//ctx.Fail(ecode.UnknownErr) //todo
-		//return
+		ctx.Fail(ecode.UnknownErr)
+		return
 	}
 
 	err = model.WithTransaction(func(db *gorm.DB) error {
@@ -266,27 +265,24 @@
 	if plcConfig.CurrentTryTimes > plcConfig.MaxTryTimes {
 		return plcConfig.CurrentErr
 	}
-	conn, err := plc.GetModbusConnection(fmt.Sprintf("%s:%v", plcConfig.Address, plcConfig.Port))
-	if err != nil {
-		return errors.New(fmt.Sprintf("杩炴帴plc澶辫触: %v", err.Error()))
-	}
 	if plcConfig.CurrentTryTimes == 0 {
 		logx.Info("----------------寮�濮嬩笅鍙戝伐鑹哄弬鏁�-----------------")
 	}
 	var failedNumbers int
 	for k, v := range paramsMap {
-		if address, ok := plc_address.Get(k); ok {
-			result, err := plc.WriteHoldingRegister(conn, address, v)
-			if err != nil {
-				plcConfig.CurrentErr = err
-				failedNumbers++
-				logx.Errorf("plc write err:%v, address: %v, key: %v value: %v", err.Error(), address, k, v)
-			} else {
-				delete(paramsMap, k)
-				logx.Infof("plc write ok: key: %v, value: %v, result: %v", k, v, result)
-			}
-		} else {
+		address, ok := plc_address.Get(k)
+		if !ok {
 			logx.Errorf("miss param address, k:%v, v:%v", k, v)
+			continue
+		}
+		err := service.PlcWriteDirect(plcConfig, address, v)
+		if err != nil {
+			plcConfig.CurrentErr = err
+			failedNumbers++
+			logx.Errorf("plc write err:%v, address: %v, key: %v value: %v", err.Error(), address, k, v)
+		} else {
+			delete(paramsMap, k)
+			logx.Infof("plc write ok: key: %v, value: %v", k, v)
 		}
 	}
 	if failedNumbers >= 1 { //鍐欏叆plc澶辫触, 閲嶈瘯

--
Gitblit v1.8.0