From cacf363f222e354cad6db18c4a00fb1097d35c2c Mon Sep 17 00:00:00 2001 From: zhangqian <zhangqian@123.com> Date: 星期四, 09 十一月 2023 14:30:58 +0800 Subject: [PATCH] fix --- service/plc.go | 29 +++++++++++++++++++++++++---- 1 files changed, 25 insertions(+), 4 deletions(-) diff --git a/service/plc.go b/service/plc.go index 42ad54d..ac23286 100644 --- a/service/plc.go +++ b/service/plc.go @@ -14,8 +14,12 @@ "errors" "fmt" "github.com/spf13/cast" + "sync" "sync/atomic" ) + +// 涓插彛涓嶆敮鎸佸苟琛岃鍐欙紝鎵�浠ラ渶瑕佸姞涓攣锛岄槻姝imeout鍜岃祫婧愪笉鍙敤鎶ラ敊 +var lock sync.Mutex func PlcWrite(plcConfig *model.DevicePlc, fieldType constvar.PlcStartAddressType, channel int32, value interface{}) (err error) { var ( @@ -36,10 +40,14 @@ } func PlcWriteDirect(plcConfig *model.DevicePlc, address int, value interface{}) (err error) { + lock.Lock() + defer lock.Unlock() var ( ipAddr string ) - defer dealErr(err) + defer func() { + dealErr(err) + }() if plcConfig.Method == constvar.PlcMethodModbusTCP { ipAddr = fmt.Sprintf("%s:%v", plcConfig.Address, plcConfig.Port) err = WriteByModbusTCP(ipAddr, address, value) @@ -70,10 +78,14 @@ } func PlcReadDirect(plcConfig *model.DevicePlc, address int, dataLength int, valueType constvar.PlcStartAddressValueType) (val interface{}, err error) { + lock.Lock() + defer lock.Unlock() var ( ipAddr string ) - defer dealErr(err) + defer func() { + dealErr(err) + }() if plcConfig.Method == constvar.PlcMethodModbusTCP || plcConfig.Method == constvar.PlcMethodModbusRTU { var value []byte if plcConfig.Method == constvar.PlcMethodModbusTCP { @@ -92,7 +104,16 @@ switch valueType { case constvar.PlcStartAddressValueTypeString: return string(value), nil - case constvar.PlcStartAddressValueTypeInt: + case constvar.PlcStartAddressValueTypeInt32: + if len(value) == 2 { + val = binary.BigEndian.Uint16(value) + } else if len(value) == 4 { + val = binary.BigEndian.Uint32(value) + } else { + logx.Errorf("plc read get an unknown int value: %v, address:%v", value, address) + return nil, errors.New(fmt.Sprintf("unknown int value锛�%v", value)) + } + default: if len(value) == 2 { val = binary.BigEndian.Uint16(value) } else if len(value) == 4 { @@ -104,7 +125,7 @@ return nil, errors.New(fmt.Sprintf("unknown int value锛�%v", value)) } } - logx.Infof("plc read ok, address: %v, result: %v, dataLength: %v, valueLength: %v", address, val, dataLength, len(value)) + logx.Infof("plc read ok, address: %v, result: %v, dataLength: %v, value: %v", address, val, dataLength, value) return val, nil } else if plcConfig.Method == constvar.PlcMethodSerial { ipAddr = conf.Conf.Services.Serial -- Gitblit v1.8.0