From 8324f872ef3a4d0c978a9b1d062800c6a1701c12 Mon Sep 17 00:00:00 2001 From: zhangqian <zhangqian@123.com> Date: 星期五, 01 十二月 2023 09:58:17 +0800 Subject: [PATCH] fix --- service/plc.go | 53 ++++++++++++++++++++++++++++++++++++----------------- 1 files changed, 36 insertions(+), 17 deletions(-) diff --git a/service/plc.go b/service/plc.go index f4428ab..c577998 100644 --- a/service/plc.go +++ b/service/plc.go @@ -15,7 +15,6 @@ "fmt" "github.com/spf13/cast" "sync" - "sync/atomic" ) // 涓插彛涓嶆敮鎸佸苟琛岃鍐欙紝鎵�浠ラ渶瑕佸姞涓攣锛岄槻姝imeout鍜岃祫婧愪笉鍙敤鎶ラ敊 @@ -45,7 +44,9 @@ var ( ipAddr string ) - defer dealErr(err) + defer func() { + dealErr(err) + }() if plcConfig.Method == constvar.PlcMethodModbusTCP { ipAddr = fmt.Sprintf("%s:%v", plcConfig.Address, plcConfig.Port) err = WriteByModbusTCP(ipAddr, address, value) @@ -81,7 +82,9 @@ var ( ipAddr string ) - defer dealErr(err) + defer func() { + dealErr(err) + }() if plcConfig.Method == constvar.PlcMethodModbusTCP || plcConfig.Method == constvar.PlcMethodModbusRTU { var value []byte if plcConfig.Method == constvar.PlcMethodModbusTCP { @@ -100,7 +103,16 @@ switch valueType { case constvar.PlcStartAddressValueTypeString: return string(value), nil - case constvar.PlcStartAddressValueTypeInt: + case constvar.PlcStartAddressValueTypeInt32: + if len(value) == 2 { + val = binary.BigEndian.Uint16(value) + } else if len(value) == 4 { + val = binary.BigEndian.Uint32(value) + } else { + logx.Errorf("plc read get an unknown int value: %v, address:%v", value, address) + return nil, errors.New(fmt.Sprintf("unknown int value锛�%v", value)) + } + default: if len(value) == 2 { val = binary.BigEndian.Uint16(value) } else if len(value) == 4 { @@ -112,7 +124,7 @@ return nil, errors.New(fmt.Sprintf("unknown int value锛�%v", value)) } } - logx.Infof("plc read ok, address: %v, result: %v, dataLength: %v, valueLength: %v", address, val, dataLength, len(value)) + logx.Infof("plc read ok, address: %v, result: %v, dataLength: %v, value: %v", address, val, dataLength, value) return val, nil } else if plcConfig.Method == constvar.PlcMethodSerial { ipAddr = conf.Conf.Services.Serial @@ -198,32 +210,39 @@ } } -var connectionStatus atomic.Bool - -var failureRemainingOpportunities atomic.Int64 +var connectionStatus sync.Map const ( defaultFailureRemainingOpportunities = 20 ) func IsConnect() bool { - return connectionStatus.Load() + val, ok := connectionStatus.Load(conf.Conf.CurrentDeviceID) + if !ok { + return false + } + failureRemainingOpportunities := val.(int) + return failureRemainingOpportunities > 0 } func FailureRemainingOpportunitiesDecr() { - newValue := failureRemainingOpportunities.Add(-1) - if newValue <= 0 { - connectionStatus.Store(false) + val, ok := connectionStatus.Load(conf.Conf.CurrentDeviceID) + if !ok { + return } + failureRemainingOpportunities := val.(int) + if failureRemainingOpportunities > 0 { + failureRemainingOpportunities-- + } + connectionStatus.Store(conf.Conf.CurrentDeviceID, failureRemainingOpportunities) return } func FailureRemainingOpportunitiesReset() { - if failureRemainingOpportunities.Load() < defaultFailureRemainingOpportunities { - failureRemainingOpportunities.Store(defaultFailureRemainingOpportunities) - } - if connectionStatus.Load() == false { - connectionStatus.Store(true) + val, ok := connectionStatus.Load(conf.Conf.CurrentDeviceID) + if !ok || val.(int) < defaultFailureRemainingOpportunities { + connectionStatus.Store(conf.Conf.CurrentDeviceID, defaultFailureRemainingOpportunities) + return } return } -- Gitblit v1.8.0