From 11f6c600e55ca5677f93624efe44d2605cdd908d Mon Sep 17 00:00:00 2001
From: lichao <lichao@aiotlink.com>
Date: 星期五, 21 五月 2021 20:18:38 +0800
Subject: [PATCH] reserve #,@ prefix for internal proc id and topic.

---
 src/topic_node.cpp |  111 ++++++++++++++++++++++++++++++++++++-------------------
 1 files changed, 72 insertions(+), 39 deletions(-)

diff --git a/src/topic_node.cpp b/src/topic_node.cpp
index 6be65be..3c38121 100644
--- a/src/topic_node.cpp
+++ b/src/topic_node.cpp
@@ -17,6 +17,7 @@
  */
 #include "topic_node.h"
 #include "bh_util.h"
+#include "sleeper.h"
 #include <chrono>
 #include <list>
 
@@ -28,6 +29,11 @@
 
 namespace
 {
+bool ValidUserSymbol(const std::string &s)
+{
+	return !s.empty() && s[0] != '#' && s[0] != '@';
+}
+
 inline void AddRoute(BHMsgHead &head, const ShmSocket &sock)
 {
 	auto route = head.add_route();
@@ -51,7 +57,6 @@
 
 TopicNode::~TopicNode()
 {
-	LOG_DEBUG() << "~TopicNode()";
 	Stop();
 }
 
@@ -66,13 +71,13 @@
 	}
 
 	if (ssn_id_ == 0) {
-		ssn_id_ = ShmMsgQueue::NewId();
+		ssn_id_ = NewSession();
 	}
 	LOG_DEBUG() << "Node Init, id " << ssn_id_;
 	auto NodeInit = [&]() {
 		int64_t init_request = ssn_id_ << 4 | EncodeCmd(eCmdNodeInit);
 		int64_t reply = 0;
-		if (BHNodeInit(init_request, reply) && DecodeCmd(reply) == eCmdNodeInitReply) {
+		if (BHNodeInit(shm(), init_request, reply) && DecodeCmd(reply) == eCmdNodeInitReply) {
 			int64_t abs_addr = reply >> 4;
 			sockets_.emplace_back(new ShmSocket(abs_addr, shm_, ssn_id_));
 			LOG_DEBUG() << "node init ok";
@@ -94,7 +99,7 @@
 				auto head = InitMsgHead(GetType(body), info_.proc_id(), ssn_id_);
 				AddRoute(head, socket);
 				if (imsg.Fill(head, body)) {
-					socket.Send(BHTopicCenterAddress(), imsg);
+					socket.Send(CenterAddr(), imsg);
 				}
 			} break;
 			case kMsgTypeProcInitReply: {
@@ -107,14 +112,9 @@
 					}
 					SetProcIndex(reply.proc_index());
 					this->state_ = eStateUnregistered;
-					auto onRequest = [this](ShmSocket &socket, MsgI &msg, BHMsgHead &head) {
-						server_buffer_->Write(std::move(head), msg.body());
-					};
-					SockServer().Start(onRequest);
-					auto onSub = [this](ShmSocket &socket, MsgI &msg, BHMsgHead &head) {
-						sub_buffer_->Write(std::move(head), msg.body());
-					};
-					SockSub().Start(onSub);
+
+					ServerStart(ServerAsyncCB(), 1);
+					SubscribeStartWorker(SubDataCB(), 1);
 				}
 			} break;
 			default: break;
@@ -145,13 +145,16 @@
 }
 void TopicNode::Stop()
 {
-	LOG_DEBUG() << "Node Stopping";
 	for (auto &p : sockets_) { p->Stop(); }
-	LOG_INFO() << "Node Stopped";
 }
 
-bool TopicNode::Register(ProcInfo &proc, MsgCommonReply &reply_body, const int timeout_ms)
+bool TopicNode::DoRegister(const bool internal, ProcInfo &proc, MsgCommonReply &reply_body, const int timeout_ms)
 {
+	if (!internal && !ValidUserSymbol(proc.proc_id())) {
+		SetLastError(eInvalidInput, "invalid proc id :'" + proc.proc_id() + "'");
+		return false;
+	}
+
 	{
 		std::lock_guard<std::mutex> lk(mutex_);
 		info_ = proc;
@@ -194,12 +197,12 @@
 			MsgCommonReply body;
 			CheckResult(imsg, head, body);
 		};
-		return sock.Send(BHTopicCenterAddress(), head, body, onResult);
+		return sock.Send(CenterAddr(), head, body, onResult);
 	} else {
-		MsgI reply;
+		MsgI reply(shm());
 		DEFER1(reply.Release(););
 		BHMsgHead reply_head;
-		bool r = sock.SendAndRecv(BHTopicCenterAddress(), head, body, reply, reply_head, timeout_ms);
+		bool r = sock.SendAndRecv(CenterAddr(), head, body, reply, reply_head, timeout_ms);
 		if (r) {
 			CheckResult(reply, reply_head, reply_body);
 		}
@@ -235,12 +238,12 @@
 			MsgCommonReply body;
 			CheckResult(imsg, head, body);
 		};
-		return sock.Send(BHTopicCenterAddress(), head, body, onResult);
+		return sock.Send(CenterAddr(), head, body, onResult);
 	} else {
-		MsgI reply;
+		MsgI reply(shm());
 		DEFER1(reply.Release(););
 		BHMsgHead reply_head;
-		bool r = sock.SendAndRecv(BHTopicCenterAddress(), head, body, reply, reply_head, timeout_ms);
+		bool r = sock.SendAndRecv(CenterAddr(), head, body, reply, reply_head, timeout_ms);
 		return r && CheckResult(reply, reply_head, reply_body);
 	}
 }
@@ -260,12 +263,12 @@
 	AddRoute(head, sock);
 
 	if (timeout_ms == 0) {
-		return sock.Send(BHTopicCenterAddress(), head, body);
+		return sock.Send(CenterAddr(), head, body);
 	} else {
-		MsgI reply;
+		MsgI reply(shm());
 		DEFER1(reply.Release(););
 		BHMsgHead reply_head;
-		bool r = sock.SendAndRecv(BHTopicCenterAddress(), head, body, reply, reply_head, timeout_ms);
+		bool r = sock.SendAndRecv(CenterAddr(), head, body, reply, reply_head, timeout_ms);
 		r = r && reply_head.type() == kMsgTypeCommonReply && reply.ParseBody(reply_body);
 		return (r && IsSuccess(reply_body.errmsg().errcode()));
 	}
@@ -289,16 +292,44 @@
 	BHMsgHead head(InitMsgHead(GetType(query), proc_id(), ssn()));
 	AddRoute(head, sock);
 
-	MsgI reply;
+	MsgI reply(shm());
 	DEFER1(reply.Release());
 	BHMsgHead reply_head;
-	return (sock.SendAndRecv(BHTopicCenterAddress(), head, query, reply, reply_head, timeout_ms) &&
+	return (sock.SendAndRecv(CenterAddr(), head, query, reply, reply_head, timeout_ms) &&
 	        reply_head.type() == kMsgTypeQueryTopicReply &&
 	        reply.ParseBody(reply_body));
 }
 
-bool TopicNode::ServerRegisterRPC(MsgTopicList &topics, MsgCommonReply &reply_body, const int timeout_ms)
+bool TopicNode::QueryProcs(BHAddress &dest, MsgQueryProc &query, MsgQueryProcReply &reply_body, const int timeout_ms)
 {
+	if (!IsOnline()) {
+		SetLastError(eNotRegistered, kErrMsgNotRegistered);
+		return false;
+	}
+	auto &sock = SockNode();
+
+	BHMsgHead head(InitMsgHead(GetType(query), proc_id(), ssn()));
+	AddRoute(head, sock);
+
+	MsgI reply(shm());
+	DEFER1(reply.Release());
+	BHMsgHead reply_head;
+	return (sock.SendAndRecv(CenterAddr(), head, query, reply, reply_head, timeout_ms) &&
+	        reply_head.type() == kMsgTypeQueryProcReply &&
+	        reply.ParseBody(reply_body));
+}
+
+bool TopicNode::DoServerRegisterRPC(const bool internal, MsgTopicList &topics, MsgCommonReply &reply_body, const int timeout_ms)
+{
+	if (!internal) {
+		for (auto &&topic : topics.topic_list()) {
+			if (!ValidUserSymbol(topic)) {
+				SetLastError(eInvalidInput, "invalid user topic :'" + topic + "'");
+				return false;
+			}
+		}
+	}
+
 	if (!IsOnline()) {
 		SetLastError(eNotRegistered, kErrMsgNotRegistered);
 		return false;
@@ -312,12 +343,12 @@
 	AddRoute(head, sock);
 
 	if (timeout_ms == 0) {
-		return sock.Send(BHTopicCenterAddress(), head, body);
+		return sock.Send(CenterAddr(), head, body);
 	} else {
-		MsgI reply;
+		MsgI reply(shm());
 		DEFER1(reply.Release(););
 		BHMsgHead reply_head;
-		bool r = sock.SendAndRecv(BHTopicCenterAddress(), head, body, reply, reply_head, timeout_ms);
+		bool r = sock.SendAndRecv(CenterAddr(), head, body, reply, reply_head, timeout_ms);
 		r = r && reply_head.type() == kMsgTypeCommonReply;
 		r = r && reply.ParseBody(reply_body);
 		return r;
@@ -385,10 +416,11 @@
 	}
 	BHMsgHead head;
 	std::string body;
+	FibUSleeper sleeper(1000 * 10);
 	auto end_time = steady_clock::now() + milliseconds(timeout_ms);
 	while (!server_buffer_->Read(head, body)) {
 		if (steady_clock::now() < end_time) {
-			robust::QuickSleep();
+			sleeper.Sleep();
 		} else {
 			return false;
 		}
@@ -512,7 +544,7 @@
 			AddRoute(head, sock);
 			head.set_topic(request.topic());
 
-			MsgI reply_msg;
+			MsgI reply_msg(shm());
 			DEFER1(reply_msg.Release(););
 			BHMsgHead reply_head;
 
@@ -583,13 +615,13 @@
 		AddRoute(head, sock);
 
 		if (timeout_ms == 0) {
-			return sock.Send(BHTopicBusAddress(), head, pub);
+			return sock.Send(BusAddr(), head, pub);
 		} else {
-			MsgI reply;
+			MsgI reply(shm());
 			DEFER1(reply.Release(););
 			BHMsgHead reply_head;
 			MsgCommonReply reply_body;
-			return sock.SendAndRecv(BHTopicBusAddress(), head, pub, reply, reply_head, timeout_ms) &&
+			return sock.SendAndRecv(BusAddr(), head, pub, reply, reply_head, timeout_ms) &&
 			       reply_head.type() == kMsgTypeCommonReply &&
 			       reply.ParseBody(reply_body) &&
 			       IsSuccess(reply_body.errmsg().errcode());
@@ -616,12 +648,12 @@
 		BHMsgHead head(InitMsgHead(GetType(sub), proc_id(), ssn()));
 		AddRoute(head, sock);
 		if (timeout_ms == 0) {
-			return sock.Send(BHTopicBusAddress(), head, sub);
+			return sock.Send(BusAddr(), head, sub);
 		} else {
-			MsgI reply;
+			MsgI reply(shm());
 			DEFER1(reply.Release(););
 			BHMsgHead reply_head;
-			return sock.SendAndRecv(BHTopicBusAddress(), head, sub, reply, reply_head, timeout_ms) &&
+			return sock.SendAndRecv(BusAddr(), head, sub, reply, reply_head, timeout_ms) &&
 			       reply_head.type() == kMsgTypeCommonReply &&
 			       reply.ParseBody(reply_body) &&
 			       IsSuccess(reply_body.errmsg().errcode());
@@ -663,10 +695,11 @@
 
 	BHMsgHead head;
 	std::string body;
+	FibUSleeper sleeper(1000 * 10);
 	auto end_time = steady_clock::now() + milliseconds(timeout_ms);
 	while (!sub_buffer_->Read(head, body)) {
 		if (steady_clock::now() < end_time) {
-			robust::QuickSleep();
+			sleeper.Sleep();
 		} else {
 			return false;
 		}

--
Gitblit v1.8.0