From a100bb2af8afc5fb61abc54e0b616cc44bb0b814 Mon Sep 17 00:00:00 2001
From: lichao <lichao@aiotlink.com>
Date: 星期五, 26 三月 2021 15:53:35 +0800
Subject: [PATCH] adjust mq length.

---
 src/shm_queue.cpp |   48 +++++++++++++++++++++++++++---------------------
 1 files changed, 27 insertions(+), 21 deletions(-)

diff --git a/src/shm_queue.cpp b/src/shm_queue.cpp
index 1446446..de4505b 100644
--- a/src/shm_queue.cpp
+++ b/src/shm_queue.cpp
@@ -29,15 +29,27 @@
 std::string MsgQIdToName(const MQId& id) { return "shmq" + to_string(id); }
 MQId EmptyId() { return nil_uuid(); }
 MQId NewId() { return random_generator()(); }
+const int AdjustMQLength(const int len) {
+    const int kMaxLength = 10000; 
+    const int kDefaultLen = 12;
+    if (len <= 0) {
+        return kDefaultLen;
+    } else if (len < kMaxLength) {
+        return len;
+    } else {
+        return kMaxLength;
+    }
 }
 
-ShmMsgQueue::ShmMsgQueue(const MQId &id, ShmType &segment, const uint32_t len):
-SharedQueue(segment, MsgQIdToName(id), id, len, segment.get_segment_manager())
+}
+
+// ShmMsgQueue memory usage: (320 + 16*length) bytes, length >= 2
+ShmMsgQueue::ShmMsgQueue(const MQId &id, ShmType &segment, const int len):
+SharedQueue(segment, MsgQIdToName(id), id, AdjustMQLength(len), segment.get_segment_manager())
 {
-    printf("queue size: %ld cap: %ld\n", data()->size(), data()->capacity());
 }
 
-ShmMsgQueue::ShmMsgQueue(ShmType &segment, const uint32_t len):ShmMsgQueue(NewId(), segment, len)
+ShmMsgQueue::ShmMsgQueue(ShmType &segment, const int len):ShmMsgQueue(NewId(), segment, len)
 {}
 
 ShmMsgQueue::~ShmMsgQueue()
@@ -48,29 +60,22 @@
 bool ShmMsgQueue::Send(const MQId &remote_id, const Msg &msg, const int timeout_ms)
 {
     Queue *remote = find(MsgQIdToName(remote_id));
-
-    return remote && remote->Write(msg, timeout_ms);
-    
-    if(!remote) {
-        return false;
-    }
-    msg.AddRef();
-    if (remote->Write(msg, timeout_ms)) {
-        return true;
-    } else {
-        msg.RemoveRef();
-        return false;
-    }
+    return remote && remote->Write(msg, timeout_ms, [&](){msg.AddRef();});
 }
 
 bool ShmMsgQueue::Send(const MQId &remote_id, const void *data, const size_t size, const int timeout_ms)
 {
+    // Test shows that in the 2 cases:
+    // 1) build msg first, then find remote queue;
+    // 2) find remote queue first, then build msg;
+    // 1 is about 50% faster than 2, maybe cache related.
+
     Msg msg;
-    if (msg.Build(shm(), Id(), data, size, false)) {
-        if (Send(remote_id, msg, timeout_ms)) {
+    if(msg.Build(shm(), Id(), data, size, false)) {
+        if(Send(remote_id, msg, timeout_ms)) {
             return true;
         } else {
-            msg.FreeFrom(shm());
+            msg.Release(shm());
         }
     }
     return false;
@@ -80,9 +85,10 @@
 {
     Msg msg;
     if (Read(msg, timeout_ms)) {
+        DEFER1(msg.Release(shm()););
+
         auto ptr = msg.get<char>();
         if (ptr) {
-            DEFER1(shm().Dealloc(ptr););
             MsgMetaV1 meta;
             meta.Parse(ptr);
             source_id = meta.src_id_;

--
Gitblit v1.8.0