From c6964d5af25d4ec7ed9dbe7674dc4e3896b36ead Mon Sep 17 00:00:00 2001
From: lichao <lichao@aiotlink.com>
Date: 星期五, 16 四月 2021 16:10:02 +0800
Subject: [PATCH] node remove mq if never registered; refactor.
---
src/topic_node.cpp | 403 ++++++++++++++++++++++++++++++++++-----------------------
1 files changed, 242 insertions(+), 161 deletions(-)
diff --git a/src/topic_node.cpp b/src/topic_node.cpp
index 5afec3f..2cc5483 100644
--- a/src/topic_node.cpp
+++ b/src/topic_node.cpp
@@ -32,71 +32,54 @@
std::string msg_id;
};
-class ServerFailedQ
-{
- struct FailedMsg {
- steady_clock::time_point xpr;
- std::string remote_;
- BHMsgHead head_;
- MsgRequestTopicReply body_;
- FailedMsg(const std::string &addr, BHMsgHead &&head, MsgRequestTopicReply &&body) :
- xpr(steady_clock::now() + 10s), remote_(addr), head_(std::move(head)), body_(std::move(body)) {}
- bool Expired() { return steady_clock::now() > xpr; }
- };
- typedef std::list<FailedMsg> Queue;
- Synced<Queue> queue_;
-
-public:
- void Push(const std::string &remote, BHMsgHead &&head, MsgRequestTopicReply &&body)
- {
- queue_->emplace_back(remote, std::move(head), std::move(body));
- }
- void TrySend(ShmSocket &socket, const int timeout_ms = 0)
- {
- queue_.Apply([&](Queue &q) {
- if (!q.empty()) {
- auto it = q.begin();
- do {
- if (it->Expired()) {
- // it->msg_.Release(socket.shm());
- it = q.erase(it);
- } else if (socket.Send(it->remote_.data(), it->head_, it->body_, timeout_ms)) {
- it = q.erase(it);
- } else {
- ++it;
- }
- } while (it != q.end());
- }
- });
- }
-};
-
} // namespace
+
TopicNode::TopicNode(SharedMemory &shm) :
- shm_(shm), sock_node_(shm), sock_request_(shm), sock_reply_(shm), sock_sub_(shm)
+ shm_(shm), sock_node_(shm), sock_client_(shm), sock_server_(shm), sock_sub_(shm), registered_(false), registered_ever_(false)
{
- SockNode().Start();
- SockClient().Start();
- SockServer().Start();
+ // recv msgs to avoid memory leak.
+ auto default_ignore_msg = [](ShmSocket &sock, MsgI &imsg, BHMsgHead &head) { return true; };
+ SockNode().Start(default_ignore_msg);
}
TopicNode::~TopicNode()
{
- StopAll();
+ Stop();
+ SockNode().Stop();
+ if (!registered_ever_) {
+ SockNode().Remove();
+ SockClient().Remove();
+ SockServer().Remove();
+ SockSub().Remove();
+ }
}
-void TopicNode::StopAll()
+void TopicNode::Start(ServerCB const &server_cb, SubDataCB const &sub_cb, RequestResultCB &client_cb, int nworker)
{
+ if (nworker < 1) {
+ nworker = 1;
+ } else if (nworker > 16) {
+ nworker = 16;
+ }
+
+ ServerStart(server_cb, nworker);
+ SubscribeStartWorker(sub_cb, nworker);
+ ClientStartWorker(client_cb, nworker);
+}
+void TopicNode::Stop()
+{
+ SockSub().Stop();
SockServer().Stop();
SockClient().Stop();
- SockNode().Stop();
}
bool TopicNode::Register(ProcInfo &proc, MsgCommonReply &reply_body, const int timeout_ms)
{
+ info_ = proc;
+
auto &sock = SockNode();
MsgRegister body;
- *body.mutable_proc() = proc;
+ body.mutable_proc()->Swap(&proc);
auto AddId = [&](const MQId &id) { body.add_addrs()->set_mq_id(&id, sizeof(id)); };
AddId(SockNode().id());
AddId(SockServer().id());
@@ -107,20 +90,74 @@
auto head(InitMsgHead(GetType(body), body.proc().proc_id()));
AddRoute(head, sock.id());
- MsgI reply;
- DEFER1(reply.Release(shm_););
- BHMsgHead reply_head;
- bool r = sock.SendAndRecv(&BHTopicCenterAddress(), head, body, reply, reply_head, timeout_ms);
- r = r && reply_head.type() == kMsgTypeCommonReply && reply.ParseBody(reply_body);
- if (r) {
- info_ = body;
+ auto CheckResult = [this](MsgI &msg, BHMsgHead &head, MsgCommonReply &rbody) {
+ bool ok = head.type() == kMsgTypeCommonReply &&
+ msg.ParseBody(rbody) &&
+ IsSuccess(rbody.errmsg().errcode());
+ if (ok) {
+ registered_ever_.store(true);
+ }
+ registered_.store(ok);
+ };
+
+ if (timeout_ms == 0) {
+ auto onResult = [this, CheckResult](ShmSocket &socket, MsgI &imsg, BHMsgHead &head) {
+ MsgCommonReply body;
+ CheckResult(imsg, head, body);
+ };
+ return sock.Send(&BHTopicCenterAddress(), head, body, onResult);
+ } else {
+ MsgI reply;
+ DEFER1(reply.Release(shm_););
+ BHMsgHead reply_head;
+ bool r = sock.SendAndRecv(&BHTopicCenterAddress(), head, body, reply, reply_head, timeout_ms);
+ if (r) {
+ CheckResult(reply, reply_head, reply_body);
+ }
+ return IsRegistered();
}
- return r;
+}
+
+bool TopicNode::Heartbeat(ProcInfo &proc, MsgCommonReply &reply_body, const int timeout_ms)
+{
+ if (!IsRegistered()) {
+ SetLastError(eNotRegistered, "Not Registered.");
+ return false;
+ }
+
+ auto &sock = SockNode();
+ MsgHeartbeat body;
+ body.mutable_proc()->Swap(&proc);
+
+ auto head(InitMsgHead(GetType(body), body.proc().proc_id()));
+ AddRoute(head, sock.id());
+
+ if (timeout_ms == 0) {
+ return sock.Send(&BHTopicCenterAddress(), head, body);
+ } else {
+ MsgI reply;
+ DEFER1(reply.Release(shm_););
+ BHMsgHead reply_head;
+ bool r = sock.SendAndRecv(&BHTopicCenterAddress(), head, body, reply, reply_head, timeout_ms);
+ r = r && reply_head.type() == kMsgTypeCommonReply && reply.ParseBody(reply_body);
+ return (r && IsSuccess(reply_body.errmsg().errcode()));
+ }
+}
+bool TopicNode::Heartbeat(const int timeout_ms)
+{
+ ProcInfo proc;
+ proc.set_proc_id(proc_id());
+ MsgCommonReply reply_body;
+ return Heartbeat(proc, reply_body, timeout_ms);
}
bool TopicNode::ServerRegisterRPC(MsgTopicList &topics, MsgCommonReply &reply_body, const int timeout_ms)
{
- //TODO check registered
+ if (!IsRegistered()) {
+ SetLastError(eNotRegistered, "Not Registered.");
+ return false;
+ }
+
auto &sock = SockServer();
MsgRegisterRPC body;
body.mutable_topics()->Swap(&topics);
@@ -128,63 +165,56 @@
auto head(InitMsgHead(GetType(body), proc_id()));
AddRoute(head, sock.id());
- MsgI reply;
- DEFER1(reply.Release(shm_););
- BHMsgHead reply_head;
- bool r = sock.SendAndRecv(&BHTopicCenterAddress(), head, body, reply, reply_head, timeout_ms);
- r = r && reply_head.type() == kMsgTypeCommonReply;
- r = r && reply.ParseBody(reply_body);
- return r;
+ if (timeout_ms == 0) {
+ return sock.Send(&BHTopicCenterAddress(), head, body);
+ } else {
+ MsgI reply;
+ DEFER1(reply.Release(shm_););
+ BHMsgHead reply_head;
+ bool r = sock.SendAndRecv(&BHTopicCenterAddress(), head, body, reply, reply_head, timeout_ms);
+ r = r && reply_head.type() == kMsgTypeCommonReply;
+ r = r && reply.ParseBody(reply_body);
+ return r;
+ }
}
-bool TopicNode::ServerStart(const OnRequest &rcb, int nworker)
+bool TopicNode::ServerStart(const ServerCB &rcb, int nworker)
{
- //TODO check registered
+ auto onRecv = [this, rcb](ShmSocket &sock, MsgI &imsg, BHMsgHead &head) {
+ if (head.type() != kMsgTypeRequestTopic || head.route_size() == 0) { return; }
+ MsgRequestTopic req;
+ if (!imsg.ParseBody(req)) { return; }
- auto failed_q = std::make_shared<ServerFailedQ>();
+ MsgRequestTopicReply reply_body;
+ if (rcb(head.proc_id(), req, reply_body)) {
+ BHMsgHead reply_head(InitMsgHead(GetType(reply_body), proc_id(), head.msg_id()));
- auto onIdle = [failed_q](ShmSocket &socket) { failed_q->TrySend(socket); };
-
- auto onRecv = [this, rcb, failed_q, onIdle](ShmSocket &sock, MsgI &imsg, BHMsgHead &head) {
- if (head.type() == kMsgTypeRequestTopic && head.route_size() > 0) {
- MsgRequestTopic req;
- if (imsg.ParseBody(req)) {
- std::string out;
- if (rcb(req.topic(), req.data(), out)) {
- MsgRequestTopicReply reply_body;
- reply_body.set_data(std::move(out));
- BHMsgHead reply_head(InitMsgHead(GetType(reply_body), proc_id(), head.msg_id()));
-
- for (int i = 0; i < head.route_size() - 1; ++i) {
- reply_head.add_route()->Swap(head.mutable_route(i));
- }
- if (!sock.Send(head.route().rbegin()->mq_id().data(), reply_head, reply_body, 10)) {
- failed_q->Push(head.route().rbegin()->mq_id(), std::move(reply_head), std::move(reply_body));
- }
- }
+ for (int i = 0; i < head.route_size() - 1; ++i) {
+ reply_head.add_route()->Swap(head.mutable_route(i));
}
- } else {
- // ignored, or dropped
+ auto &remote = head.route().rbegin()->mq_id();
+ sock.Send(remote.data(), reply_head, reply_body);
}
-
- onIdle(sock);
};
auto &sock = SockServer();
- return rcb && sock.Start(onRecv, onIdle, nworker);
+ return rcb && sock.Start(onRecv, nworker);
}
-bool TopicNode::ServerRecvRequest(void *&src_info, std::string &topic, std::string &data, const int timeout_ms)
+bool TopicNode::ServerRecvRequest(void *&src_info, std::string &proc_id, MsgRequestTopic &request, const int timeout_ms)
{
+ if (!IsRegistered()) {
+ SetLastError(eNotRegistered, "Not Registered.");
+ return false;
+ }
+
auto &sock = SockServer();
MsgI imsg;
BHMsgHead head;
if (sock.SyncRecv(imsg, head, timeout_ms) && head.type() == kMsgTypeRequestTopic) {
- MsgRequestTopic request;
if (imsg.ParseBody(request)) {
- request.mutable_topic()->swap(topic);
- request.mutable_data()->swap(data);
+ head.mutable_proc_id()->swap(proc_id);
SrcInfo *p = new SrcInfo;
p->route.assign(head.route().begin(), head.route().end());
p->msg_id = head.msg_id();
@@ -195,8 +225,13 @@
return false;
}
-bool TopicNode::ServerSendReply(void *src_info, const std::string &data, const int timeout_ms)
+bool TopicNode::ServerSendReply(void *src_info, const MsgRequestTopicReply &body)
{
+ if (!IsRegistered()) {
+ SetLastError(eNotRegistered, "Not Registered.");
+ return false;
+ }
+
auto &sock = SockServer();
SrcInfo *p = static_cast<SrcInfo *>(src_info);
@@ -204,15 +239,11 @@
if (!p || p->route.empty()) {
return false;
}
- MsgRequestTopicReply body;
- body.set_data(data);
BHMsgHead head(InitMsgHead(GetType(body), proc_id(), p->msg_id));
-
for (unsigned i = 0; i < p->route.size() - 1; ++i) {
head.add_route()->Swap(&p->route[i]);
}
-
- return sock.Send(p->route.back().mq_id().data(), head, body, timeout_ms);
+ return sock.Send(p->route.back().mq_id().data(), head, body);
}
bool TopicNode::ClientStartWorker(RequestResultCB const &cb, const int nworker)
@@ -224,93 +255,120 @@
if (head.type() == kMsgTypeRequestTopicReply) {
MsgRequestTopicReply reply;
if (imsg.ParseBody(reply)) {
- cb(reply.data());
+ cb(head, reply);
}
}
};
- return SockRequest().Start(onData, nworker);
+ return SockClient().Start(onData, nworker);
}
-bool TopicNode::ClientAsyncRequest(const Topic &topic, const void *data, const size_t size, const int timeout_ms, const RequestResultCB &cb)
+bool TopicNode::ClientAsyncRequest(const MsgRequestTopic &req, std::string &out_msg_id, const RequestResultCB &cb)
{
- auto Call = [&](const void *remote) {
- auto &sock = SockRequest();
+ if (!IsRegistered()) {
+ SetLastError(eNotRegistered, "Not Registered.");
+ return false;
+ }
- MsgRequestTopic req;
- req.set_topic(topic);
- req.set_data(data, size);
- BHMsgHead head(InitMsgHead(GetType(req), proc_id()));
+ const std::string &msg_id(NewMsgId());
+
+ out_msg_id = msg_id;
+
+ auto SendTo = [this, msg_id](const BHAddress &addr, const MsgRequestTopic &req, const RequestResultCB &cb) {
+ auto &sock = SockClient();
+ BHMsgHead head(InitMsgHead(GetType(req), proc_id(), msg_id));
AddRoute(head, sock.id());
+ head.set_topic(req.topic());
if (cb) {
auto onRecv = [cb](ShmSocket &sock, MsgI &imsg, BHMsgHead &head) {
if (head.type() == kMsgTypeRequestTopicReply) {
MsgRequestTopicReply reply;
if (imsg.ParseBody(reply)) {
- cb(reply.data());
+ cb(head, reply);
}
}
};
- return sock.Send(remote, head, req, timeout_ms, onRecv);
+ return sock.Send(addr.mq_id().data(), head, req, onRecv);
} else {
- return sock.Send(remote, head, req, timeout_ms);
+ return sock.Send(addr.mq_id().data(), head, req);
}
};
try {
+ auto &sock = SockClient();
BHAddress addr;
- if (ClientQueryRPCTopic(topic, addr, timeout_ms)) {
- return Call(addr.mq_id().data());
- } else {
- return false;
+
+ if (topic_query_cache_.Find(req.topic(), addr)) {
+ return SendTo(addr, req, cb);
}
+
+ MsgQueryTopic query;
+ query.set_topic(req.topic());
+ BHMsgHead head(InitMsgHead(GetType(query), proc_id()));
+ AddRoute(head, sock.id());
+
+ auto onQueryResult = [this, SendTo, req, cb](ShmSocket &sock, MsgI &imsg, BHMsgHead &head) {
+ MsgQueryTopicReply rep;
+ if (head.type() == kMsgTypeQueryTopicReply && imsg.ParseBody(rep)) {
+ auto &addr = rep.address();
+ if (!addr.mq_id().empty()) {
+ topic_query_cache_.Update(req.topic(), addr);
+ SendTo(addr, req, cb);
+ }
+ }
+ };
+ return sock.Send(&BHTopicCenterAddress(), head, query, onQueryResult);
+
} catch (...) {
+ SetLastError(eError, "internal error.");
return false;
}
}
-bool TopicNode::ClientSyncRequest(const Topic &topic, const void *data, const size_t size, std::string &out, const int timeout_ms)
+bool TopicNode::ClientSyncRequest(const MsgRequestTopic &request, std::string &out_proc_id, MsgRequestTopicReply &out_reply, const int timeout_ms)
{
+ if (!IsRegistered()) {
+ SetLastError(eNotRegistered, "Not Registered.");
+ return false;
+ }
+
try {
- auto &sock = SockRequest();
+ auto &sock = SockClient();
BHAddress addr;
- if (ClientQueryRPCTopic(topic, addr, timeout_ms)) {
-
- MsgRequestTopic req;
- req.set_topic(topic);
- req.set_data(data, size);
- BHMsgHead head(InitMsgHead(GetType(req), proc_id()));
+ if (ClientQueryRPCTopic(request.topic(), addr, timeout_ms)) {
+ BHMsgHead head(InitMsgHead(GetType(request), proc_id()));
AddRoute(head, sock.id());
+ head.set_topic(request.topic());
- MsgI reply;
- DEFER1(reply.Release(shm_););
+ MsgI reply_msg;
+ DEFER1(reply_msg.Release(shm_););
BHMsgHead reply_head;
- if (sock.SendAndRecv(addr.mq_id().data(), head, req, reply, reply_head, timeout_ms) && reply_head.type() == kMsgTypeRequestTopicReply) {
- MsgRequestTopicReply dr;
- if (reply.ParseBody(dr)) {
- dr.mutable_data()->swap(out);
- return true;
- } else {
- printf("error parse reply.\n");
- }
- } else {
- printf("error recv data. line: %d\n", __LINE__);
+ if (sock.SendAndRecv(addr.mq_id().data(), head, request, reply_msg, reply_head, timeout_ms) &&
+ reply_head.type() == kMsgTypeRequestTopicReply &&
+ reply_msg.ParseBody(out_reply)) {
+ reply_head.mutable_proc_id()->swap(out_proc_id);
+ return true;
}
} else {
- printf("error recv data. line: %d\n", __LINE__);
+ SetLastError(eNotFound, "remote not found.");
}
} catch (...) {
- printf("error recv data. line: %d\n", __LINE__);
+ SetLastError(eError, __func__ + std::string(" internal errer."));
}
return false;
}
bool TopicNode::ClientQueryRPCTopic(const Topic &topic, bhome::msg::BHAddress &addr, const int timeout_ms)
{
- auto &sock = SockRequest();
+ if (!IsRegistered()) {
+ SetLastError(eNotRegistered, "Not Registered.");
+ return false;
+ }
+
+ auto &sock = SockClient();
if (topic_query_cache_.Find(topic, addr)) {
return true;
@@ -345,25 +403,30 @@
// publish
-bool TopicNode::Publish(const Topic &topic, const void *data, const size_t size, const int timeout_ms)
+bool TopicNode::Publish(const MsgPublish &pub, const int timeout_ms)
{
+ if (!IsRegistered()) {
+ SetLastError(eNotRegistered, "Not Registered.");
+ return false;
+ }
+
try {
auto &sock = SockPub();
-
- MsgPublish pub;
- pub.set_topic(topic);
- pub.set_data(data, size);
BHMsgHead head(InitMsgHead(GetType(pub), proc_id()));
AddRoute(head, sock.id());
- MsgI reply;
- DEFER1(reply.Release(shm()););
- BHMsgHead reply_head;
- MsgCommonReply reply_body;
- return sock.SendAndRecv(&BHTopicBusAddress(), head, pub, reply, reply_head, timeout_ms) &&
- reply_head.type() == kMsgTypeCommonReply &&
- reply.ParseBody(reply_body) &&
- IsSuccess(reply_body.errmsg().errcode());
+ if (timeout_ms == 0) {
+ return sock.Send(&BHTopicBusAddress(), head, pub);
+ } else {
+ MsgI reply;
+ DEFER1(reply.Release(shm()););
+ BHMsgHead reply_head;
+ MsgCommonReply reply_body;
+ return sock.SendAndRecv(&BHTopicBusAddress(), head, pub, reply, reply_head, timeout_ms) &&
+ reply_head.type() == kMsgTypeCommonReply &&
+ reply.ParseBody(reply_body) &&
+ IsSuccess(reply_body.errmsg().errcode());
+ }
} catch (...) {
}
return false;
@@ -371,8 +434,13 @@
// subscribe
-bool TopicNode::Subscribe(MsgTopicList &topics, const int timeout_ms)
+bool TopicNode::Subscribe(MsgTopicList &topics, MsgCommonReply &reply_body, const int timeout_ms)
{
+ if (!IsRegistered()) {
+ SetLastError(eNotRegistered, "Not Registered.");
+ return false;
+ }
+
try {
auto &sock = SockSub();
MsgSubscribe sub;
@@ -380,14 +448,24 @@
BHMsgHead head(InitMsgHead(GetType(sub), proc_id()));
AddRoute(head, sock.id());
-
- return sock.Send(&BHTopicBusAddress(), head, sub, timeout_ms);
+ if (timeout_ms == 0) {
+ return sock.Send(&BHTopicBusAddress(), head, sub);
+ } else {
+ MsgI reply;
+ DEFER1(reply.Release(shm()););
+ BHMsgHead reply_head;
+ return sock.SendAndRecv(&BHTopicBusAddress(), head, sub, reply, reply_head, timeout_ms) &&
+ reply_head.type() == kMsgTypeCommonReply &&
+ reply.ParseBody(reply_body) &&
+ IsSuccess(reply_body.errmsg().errcode());
+ }
+ // TODO wait for result?
} catch (...) {
return false;
}
}
-bool TopicNode::SubscribeStartWorker(const TopicDataCB &tdcb, int nworker)
+bool TopicNode::SubscribeStartWorker(const SubDataCB &tdcb, int nworker)
{
auto &sock = SockSub();
@@ -395,7 +473,7 @@
if (head.type() == kMsgTypePublish) {
MsgPublish pub;
if (imsg.ParseBody(pub)) {
- tdcb(head.proc_id(), pub.topic(), pub.data());
+ tdcb(head.proc_id(), pub);
}
} else {
// ignored, or dropped
@@ -405,18 +483,21 @@
return tdcb && sock.Start(AsyncRecvProc, nworker);
}
-bool TopicNode::RecvSub(std::string &proc_id, Topic &topic, std::string &data, const int timeout_ms)
+bool TopicNode::RecvSub(std::string &proc_id, MsgPublish &pub, const int timeout_ms)
{
+ if (!IsRegistered()) {
+ SetLastError(eNotRegistered, "Not Registered.");
+ return false;
+ }
+
auto &sock = SockSub();
MsgI msg;
DEFER1(msg.Release(shm()););
BHMsgHead head;
+ //TODO error msg.
if (sock.SyncRecv(msg, head, timeout_ms) && head.type() == kMsgTypePublish) {
- MsgPublish pub;
if (msg.ParseBody(pub)) {
head.mutable_proc_id()->swap(proc_id);
- pub.mutable_topic()->swap(topic);
- pub.mutable_data()->swap(data);
return true;
}
}
--
Gitblit v1.8.0