From cab831748a2a9cc18b7f18f3b5e14a4374b7ab68 Mon Sep 17 00:00:00 2001
From: lichao <lichao@aiotlink.com>
Date: 星期一, 17 五月 2021 18:34:26 +0800
Subject: [PATCH] socket send using abs addr, avoid shm find by id.

---
 src/topic_node.cpp |  100 +++++++++++++++++++++++++++++++-------------------
 1 files changed, 62 insertions(+), 38 deletions(-)

diff --git a/src/topic_node.cpp b/src/topic_node.cpp
index 35228b4..51a0ab7 100644
--- a/src/topic_node.cpp
+++ b/src/topic_node.cpp
@@ -28,7 +28,12 @@
 
 namespace
 {
-inline void AddRoute(BHMsgHead &head, const MQId id) { head.add_route()->set_mq_id(id); }
+inline void AddRoute(BHMsgHead &head, const ShmSocket &sock)
+{
+	auto route = head.add_route();
+	route->set_mq_id(sock.id());
+	route->set_abs_addr(sock.AbsAddr());
+}
 
 struct SrcInfo {
 	std::vector<BHAddress> route;
@@ -40,7 +45,7 @@
 } // namespace
 
 TopicNode::TopicNode(SharedMemory &shm) :
-    shm_(shm), state_(eStateUnregistered)
+    shm_(shm), state_(eStateUninited)
 {
 }
 
@@ -79,6 +84,7 @@
 			auto end_time = steady_clock::now() + 3s;
 			do {
 				try {
+					//TODO recv offset, avoid query.
 					for (int i = eSockStart; i < eSockEnd; ++i) {
 						sockets_.emplace_back(new ShmSocket(shm_, false, ssn_id_ + i, kMqLen));
 					}
@@ -94,7 +100,6 @@
 		NodeInit();
 	}
 	if (!sockets_.empty()) {
-		LOG_DEBUG() << "node sockets ok";
 		auto onNodeCmd = [this](ShmSocket &socket, int64_t &val) {
 			LOG_DEBUG() << "node recv cmd: " << DecodeCmd(val);
 			switch (DecodeCmd(val)) {
@@ -103,7 +108,7 @@
 				DEFER1(msg.Release());
 				MsgProcInit body;
 				auto head = InitMsgHead(GetType(body), info_.proc_id(), ssn_id_);
-				head.add_route()->set_mq_id(ssn_id_);
+				AddRoute(head, socket);
 				if (msg.Fill(head, body)) {
 					socket.Send(BHTopicCenterAddress(), msg);
 				}
@@ -122,12 +127,12 @@
 				MsgProcInitReply reply;
 				if (imsg.ParseBody(reply)) {
 					SetProcIndex(reply.proc_index());
+					this->state_ = eStateUnregistered;
 				}
 			}
 			return true;
 		};
 		SockNode().Start(1, onMsg, onNodeCmd);
-		LOG_DEBUG() << "sockets ok.";
 		return true;
 	}
 	return false;
@@ -167,19 +172,22 @@
 		SetLastError(eError, kErrMsgNotInit);
 		return false;
 	}
+	auto end_time = steady_clock::now() + milliseconds(timeout_ms);
+
+	while (state_ != eStateUnregistered && steady_clock::now() < end_time) {
+		std::this_thread::yield();
+	}
+	if (state_ != eStateUnregistered) {
+		SetLastError(eError, kErrMsgNotInit);
+		return false;
+	}
 
 	auto &sock = SockNode();
 	MsgRegister body;
 	body.mutable_proc()->Swap(&proc);
-	auto AddId = [&](const MQId id) { body.add_addrs()->set_mq_id(id); };
-	AddId(SockNode().id());
-	AddId(SockServer().id());
-	AddId(SockClient().id());
-	AddId(SockSub().id());
-	AddId(SockPub().id());
 
 	auto head(InitMsgHead(GetType(body), body.proc().proc_id(), ssn()));
-	AddRoute(head, sock.id());
+	AddRoute(head, sock);
 
 	auto CheckResult = [this](MsgI &msg, BHMsgHead &head, MsgCommonReply &rbody) {
 		bool ok = head.type() == kMsgTypeCommonReply &&
@@ -224,7 +232,7 @@
 	body.mutable_proc()->Swap(&proc);
 
 	auto head(InitMsgHead(GetType(body), body.proc().proc_id(), ssn()));
-	AddRoute(head, sock.id());
+	AddRoute(head, sock);
 
 	auto CheckResult = [this](MsgI &msg, BHMsgHead &head, MsgCommonReply &rbody) {
 		bool r = head.type() == kMsgTypeCommonReply &&
@@ -260,7 +268,7 @@
 	body.mutable_proc()->Swap(&proc);
 
 	auto head(InitMsgHead(GetType(body), body.proc().proc_id(), ssn()));
-	AddRoute(head, sock.id());
+	AddRoute(head, sock);
 
 	if (timeout_ms == 0) {
 		return sock.Send(BHTopicCenterAddress(), head, body);
@@ -290,7 +298,7 @@
 	auto &sock = SockNode();
 
 	BHMsgHead head(InitMsgHead(GetType(query), proc_id(), ssn()));
-	AddRoute(head, sock.id());
+	AddRoute(head, sock);
 
 	MsgI reply;
 	DEFER1(reply.Release());
@@ -312,7 +320,7 @@
 	body.mutable_topics()->Swap(&topics);
 
 	auto head(InitMsgHead(GetType(body), proc_id(), ssn()));
-	AddRoute(head, sock.id());
+	AddRoute(head, sock);
 
 	if (timeout_ms == 0) {
 		return sock.Send(BHTopicCenterAddress(), head, body);
@@ -341,7 +349,7 @@
 			for (int i = 0; i < head.route_size() - 1; ++i) {
 				reply_head.add_route()->Swap(head.mutable_route(i));
 			}
-			auto remote = head.route().rbegin()->mq_id();
+			MQInfo remote = {head.route().rbegin()->mq_id(), head.route().rbegin()->abs_addr()};
 			sock.Send(remote, reply_head, reply_body);
 		}
 	};
@@ -357,10 +365,17 @@
 		MsgRequestTopic req;
 		if (!imsg.ParseBody(req)) { return; }
 
-		SrcInfo *p = new SrcInfo;
-		p->route.assign(head.route().begin(), head.route().end());
-		p->msg_id = head.msg_id();
-		acb(p, *head.mutable_proc_id(), req);
+		try {
+			SrcInfo *p = new SrcInfo;
+			if (!p) {
+				throw std::runtime_error("no memory.");
+			}
+			p->route.assign(head.route().begin(), head.route().end());
+			p->msg_id = head.msg_id();
+			acb(p, *head.mutable_proc_id(), req);
+		} catch (std::exception &e) {
+			LOG_ERROR() << "error server handle msg:" << e.what();
+		}
 	};
 
 	auto &sock = SockServer();
@@ -381,11 +396,19 @@
 	if (sock.SyncRecv(imsg, head, timeout_ms) && head.type() == kMsgTypeRequestTopic) {
 		if (imsg.ParseBody(request)) {
 			head.mutable_proc_id()->swap(proc_id);
-			SrcInfo *p = new SrcInfo;
-			p->route.assign(head.route().begin(), head.route().end());
-			p->msg_id = head.msg_id();
-			src_info = p;
-			return true;
+			try {
+				SrcInfo *p = new SrcInfo;
+				if (!p) {
+					throw std::runtime_error("no memory.");
+				}
+				p->route.assign(head.route().begin(), head.route().end());
+				p->msg_id = head.msg_id();
+				src_info = p;
+				return true;
+			} catch (std::exception &e) {
+				LOG_ERROR() << "error recv request: " << e.what();
+				return false;
+			}
 		}
 	}
 	return false;
@@ -409,7 +432,8 @@
 	for (unsigned i = 0; i < p->route.size() - 1; ++i) {
 		head.add_route()->Swap(&p->route[i]);
 	}
-	return sock.Send(p->route.back().mq_id(), head, body);
+	MQInfo dest = {p->route.back().mq_id(), p->route.back().abs_addr()};
+	return sock.Send(dest, head, body);
 }
 
 bool TopicNode::ClientStartWorker(RequestResultCB const &cb, const int nworker)
@@ -440,10 +464,10 @@
 
 	out_msg_id = msg_id;
 
-	auto SendTo = [this, msg_id](const BHAddress &addr, const MsgRequestTopic &req, const RequestResultCB &cb) {
+	auto SendTo = [this, msg_id](const MQInfo &remote, const MsgRequestTopic &req, const RequestResultCB &cb) {
 		auto &sock = SockClient();
 		BHMsgHead head(InitMsgHead(GetType(req), proc_id(), ssn(), msg_id));
-		AddRoute(head, sock.id());
+		AddRoute(head, sock);
 		head.set_topic(req.topic());
 
 		if (cb) {
@@ -455,15 +479,15 @@
 					}
 				}
 			};
-			return sock.Send(addr.mq_id(), head, req, onRecv);
+			return sock.Send(remote, head, req, onRecv);
 		} else {
-			return sock.Send(addr.mq_id(), head, req);
+			return sock.Send(remote, head, req);
 		}
 	};
 
 	try {
 		BHAddress addr;
-		return (ClientQueryRPCTopic(req.topic(), addr, 3000)) && SendTo(addr, req, cb);
+		return (ClientQueryRPCTopic(req.topic(), addr, 3000)) && SendTo(MQInfo{addr.mq_id(), addr.abs_addr()}, req, cb);
 	} catch (...) {
 		SetLastError(eError, "internal error.");
 		return false;
@@ -484,14 +508,14 @@
 		if (ClientQueryRPCTopic(request.topic(), addr, timeout_ms)) {
 			LOG_TRACE() << "node: " << SockNode().id() << ", topic dest: " << addr.mq_id();
 			BHMsgHead head(InitMsgHead(GetType(request), proc_id(), ssn()));
-			AddRoute(head, sock.id());
+			AddRoute(head, sock);
 			head.set_topic(request.topic());
 
 			MsgI reply_msg;
 			DEFER1(reply_msg.Release(););
 			BHMsgHead reply_head;
 
-			if (sock.SendAndRecv(addr.mq_id(), head, request, reply_msg, reply_head, timeout_ms) &&
+			if (sock.SendAndRecv({addr.mq_id(), addr.abs_addr()}, head, request, reply_msg, reply_head, timeout_ms) &&
 			    reply_head.type() == kMsgTypeRequestTopicReply &&
 			    reply_msg.ParseBody(out_reply)) {
 				reply_head.mutable_proc_id()->swap(out_proc_id);
@@ -504,7 +528,7 @@
 	return false;
 }
 
-int TopicNode::QueryRPCTopics(const Topic &topic, std::vector<NodeAddress> &addr, const int timeout_ms)
+int TopicNode::QueryTopicServers(const Topic &topic, std::vector<NodeAddress> &addr, const int timeout_ms)
 {
 	int n = 0;
 	MsgQueryTopic query;
@@ -532,7 +556,7 @@
 		return true;
 	}
 	std::vector<NodeAddress> lst;
-	if (QueryRPCTopics(topic, lst, timeout_ms)) {
+	if (QueryTopicServers(topic, lst, timeout_ms)) {
 		addr = lst.front().addr();
 		if (addr.mq_id() != 0) {
 			topic_query_cache_.Store(topic, addr);
@@ -555,7 +579,7 @@
 	try {
 		auto &sock = SockPub();
 		BHMsgHead head(InitMsgHead(GetType(pub), proc_id(), ssn()));
-		AddRoute(head, sock.id());
+		AddRoute(head, sock);
 
 		if (timeout_ms == 0) {
 			return sock.Send(BHTopicBusAddress(), head, pub);
@@ -589,7 +613,7 @@
 		sub.mutable_topics()->Swap(&topics);
 
 		BHMsgHead head(InitMsgHead(GetType(sub), proc_id(), ssn()));
-		AddRoute(head, sock.id());
+		AddRoute(head, sock);
 		if (timeout_ms == 0) {
 			return sock.Send(BHTopicBusAddress(), head, sub);
 		} else {

--
Gitblit v1.8.0