From d3e7f93e69cb24c766292d8780e745caf24d42a8 Mon Sep 17 00:00:00 2001
From: lichao <lichao@aiotlink.com>
Date: 星期四, 25 三月 2021 18:30:51 +0800
Subject: [PATCH] add ref count.
---
src/shm_queue.cpp | 48 ++++++++++++++++++++++++++++++------------------
1 files changed, 30 insertions(+), 18 deletions(-)
diff --git a/src/shm_queue.cpp b/src/shm_queue.cpp
index 263fd94..77add97 100644
--- a/src/shm_queue.cpp
+++ b/src/shm_queue.cpp
@@ -45,25 +45,36 @@
Remove();
}
+bool ShmMsgQueue::Send(const MQId &remote_id, const Msg &msg, const int timeout_ms)
+{
+ Queue *remote = find(MsgQIdToName(remote_id));
+
+ if(!remote) {
+ return false;
+ }
+ msg.AddRef();
+ if (remote->Write(msg, timeout_ms)) {
+ return true;
+ } else {
+ msg.RemoveRef();
+ return false;
+ }
+}
+
bool ShmMsgQueue::Send(const MQId &remote_id, const void *data, const size_t size, const int timeout_ms)
{
- if (data && size) {
- Queue *remote = find(MsgQIdToName(remote_id));
- if (remote) {
- void *p = shm().allocate(sizeof(MsgMetaV1) + size, std::nothrow);
- bool r = false;
- if (p) {
- MsgMetaV1 meta;
- meta.data_size_ = size;
- memcpy(meta.src_id_, &Id(), sizeof(MQId));
- meta.Pack(p);
+ // Test shows that in the 2 cases:
+ // 1) build msg first, then find remote queue;
+ // 2) find remote queue first, then build msg;
+ // 1 is about 50% faster than 2, maybe cache related.
- memcpy(static_cast<char*>(p) + sizeof(meta), data, size);
- if (remote->Write(p, timeout_ms)) {
- return true;
- } else {
- shm().deallocate(p);
- }
+ Msg msg;
+ if (msg.Build(shm(), Id(), data, size, false)) {
+ if (Send(remote_id, msg, timeout_ms)) {
+ return true;
+ } else {
+ if (msg.RemoveRef() == 0) { // works for both refcounted and not counted.
+ msg.FreeFrom(shm());
}
}
}
@@ -74,12 +85,13 @@
{
Msg msg;
if (Read(msg, timeout_ms)) {
+ DEFER1(if (msg.RemoveRef() == 0) { msg.FreeFrom(shm()); });
+
auto ptr = msg.get<char>();
if (ptr) {
- DEFER1(shm().deallocate(ptr););
MsgMetaV1 meta;
meta.Parse(ptr);
- memcpy(&source_id, meta.src_id_, sizeof(MQId));
+ source_id = meta.src_id_;
size = meta.data_size_;
data = malloc(size);
if (data) {
--
Gitblit v1.8.0