From 58d904a328c0d849769b483e901a0be9426b8209 Mon Sep 17 00:00:00 2001
From: liuxiaolong <liuxiaolong@aiotlink.com>
Date: 星期二, 20 七月 2021 20:20:44 +0800
Subject: [PATCH] 调整Request C.BHFree的位置

---
 src/topic_node.cpp |  151 +++++++++++++++++++++++++++++++-------------------
 1 files changed, 93 insertions(+), 58 deletions(-)

diff --git a/src/topic_node.cpp b/src/topic_node.cpp
index 8bbb929..6096fbb 100644
--- a/src/topic_node.cpp
+++ b/src/topic_node.cpp
@@ -17,6 +17,7 @@
  */
 #include "topic_node.h"
 #include "bh_util.h"
+#include "sleeper.h"
 #include <chrono>
 #include <list>
 
@@ -28,6 +29,11 @@
 
 namespace
 {
+bool ValidUserSymbol(const std::string &s)
+{
+	return !s.empty() && s[0] != '#' && s[0] != '@';
+}
+
 inline void AddRoute(BHMsgHead &head, const ShmSocket &sock)
 {
 	auto route = head.add_route();
@@ -44,14 +50,13 @@
 
 } // namespace
 
-TopicNode::TopicNode(SharedMemory &shm) :
-    shm_(shm), state_(eStateUninited)
+TopicNode::TopicNode(SharedMemory &shm, MQId ssn_id) :
+    shm_(shm), state_(eStateUninited), ssn_id_(ssn_id)
 {
 }
 
 TopicNode::~TopicNode()
 {
-	LOG_DEBUG() << "~TopicNode()";
 	Stop();
 }
 
@@ -66,13 +71,13 @@
 	}
 
 	if (ssn_id_ == 0) {
-		ssn_id_ = ShmMsgQueue::NewId();
+		ssn_id_ = NewSession();
 	}
 	LOG_DEBUG() << "Node Init, id " << ssn_id_;
 	auto NodeInit = [&]() {
 		int64_t init_request = ssn_id_ << 4 | EncodeCmd(eCmdNodeInit);
 		int64_t reply = 0;
-		if (BHNodeInit(init_request, reply) && DecodeCmd(reply) == eCmdNodeInitReply) {
+		if (BHNodeInit(shm(), init_request, reply) && DecodeCmd(reply) == eCmdNodeInitReply) {
 			int64_t abs_addr = reply >> 4;
 			sockets_.emplace_back(new ShmSocket(abs_addr, shm_, ssn_id_));
 			LOG_DEBUG() << "node init ok";
@@ -94,7 +99,7 @@
 				auto head = InitMsgHead(GetType(body), info_.proc_id(), ssn_id_);
 				AddRoute(head, socket);
 				if (imsg.Fill(head, body)) {
-					socket.Send(BHTopicCenterAddress(), imsg);
+					socket.Send(CenterAddr(), imsg);
 				}
 			} break;
 			case kMsgTypeProcInitReply: {
@@ -140,13 +145,16 @@
 }
 void TopicNode::Stop()
 {
-	LOG_DEBUG() << "Node Stopping";
 	for (auto &p : sockets_) { p->Stop(); }
-	LOG_INFO() << "Node Stopped";
 }
 
-bool TopicNode::Register(ProcInfo &proc, MsgCommonReply &reply_body, const int timeout_ms)
+bool TopicNode::DoRegister(const bool internal, ProcInfo &proc, MsgCommonReply &reply_body, const int timeout_ms)
 {
+	if (!internal && !ValidUserSymbol(proc.proc_id())) {
+		SetLastError(eInvalidInput, "invalid proc id :'" + proc.proc_id() + "'");
+		return false;
+	}
+
 	{
 		std::lock_guard<std::mutex> lk(mutex_);
 		info_ = proc;
@@ -189,12 +197,12 @@
 			MsgCommonReply body;
 			CheckResult(imsg, head, body);
 		};
-		return sock.Send(BHTopicCenterAddress(), head, body, onResult);
+		return sock.Send(CenterAddr(), head, body, onResult);
 	} else {
-		MsgI reply;
+		MsgI reply(shm());
 		DEFER1(reply.Release(););
 		BHMsgHead reply_head;
-		bool r = sock.SendAndRecv(BHTopicCenterAddress(), head, body, reply, reply_head, timeout_ms);
+		bool r = sock.SendAndRecv(CenterAddr(), head, body, reply, reply_head, timeout_ms);
 		if (r) {
 			CheckResult(reply, reply_head, reply_body);
 		}
@@ -230,12 +238,12 @@
 			MsgCommonReply body;
 			CheckResult(imsg, head, body);
 		};
-		return sock.Send(BHTopicCenterAddress(), head, body, onResult);
+		return sock.Send(CenterAddr(), head, body, onResult);
 	} else {
-		MsgI reply;
+		MsgI reply(shm());
 		DEFER1(reply.Release(););
 		BHMsgHead reply_head;
-		bool r = sock.SendAndRecv(BHTopicCenterAddress(), head, body, reply, reply_head, timeout_ms);
+		bool r = sock.SendAndRecv(CenterAddr(), head, body, reply, reply_head, timeout_ms);
 		return r && CheckResult(reply, reply_head, reply_body);
 	}
 }
@@ -255,12 +263,12 @@
 	AddRoute(head, sock);
 
 	if (timeout_ms == 0) {
-		return sock.Send(BHTopicCenterAddress(), head, body);
+		return sock.Send(CenterAddr(), head, body);
 	} else {
-		MsgI reply;
+		MsgI reply(shm());
 		DEFER1(reply.Release(););
 		BHMsgHead reply_head;
-		bool r = sock.SendAndRecv(BHTopicCenterAddress(), head, body, reply, reply_head, timeout_ms);
+		bool r = sock.SendAndRecv(CenterAddr(), head, body, reply, reply_head, timeout_ms);
 		r = r && reply_head.type() == kMsgTypeCommonReply && reply.ParseBody(reply_body);
 		return (r && IsSuccess(reply_body.errmsg().errcode()));
 	}
@@ -284,10 +292,10 @@
 	BHMsgHead head(InitMsgHead(GetType(query), proc_id(), ssn()));
 	AddRoute(head, sock);
 
-	MsgI reply;
+	MsgI reply(shm());
 	DEFER1(reply.Release());
 	BHMsgHead reply_head;
-	return (sock.SendAndRecv(BHTopicCenterAddress(), head, query, reply, reply_head, timeout_ms) &&
+	return (sock.SendAndRecv(CenterAddr(), head, query, reply, reply_head, timeout_ms) &&
 	        reply_head.type() == kMsgTypeQueryTopicReply &&
 	        reply.ParseBody(reply_body));
 }
@@ -303,16 +311,25 @@
 	BHMsgHead head(InitMsgHead(GetType(query), proc_id(), ssn()));
 	AddRoute(head, sock);
 
-	MsgI reply;
+	MsgI reply(shm());
 	DEFER1(reply.Release());
 	BHMsgHead reply_head;
-	return (sock.SendAndRecv(BHTopicCenterAddress(), head, query, reply, reply_head, timeout_ms) &&
+	return (sock.SendAndRecv(CenterAddr(), head, query, reply, reply_head, timeout_ms) &&
 	        reply_head.type() == kMsgTypeQueryProcReply &&
 	        reply.ParseBody(reply_body));
 }
 
-bool TopicNode::ServerRegisterRPC(MsgTopicList &topics, MsgCommonReply &reply_body, const int timeout_ms)
+bool TopicNode::DoServerRegisterRPC(const bool internal, MsgTopicList &topics, MsgCommonReply &reply_body, const int timeout_ms)
 {
+	if (!internal) {
+		for (auto &&topic : topics.topic_list()) {
+			if (!ValidUserSymbol(topic)) {
+				SetLastError(eInvalidInput, "invalid user topic :'" + topic + "'");
+				return false;
+			}
+		}
+	}
+
 	if (!IsOnline()) {
 		SetLastError(eNotRegistered, kErrMsgNotRegistered);
 		return false;
@@ -326,12 +343,12 @@
 	AddRoute(head, sock);
 
 	if (timeout_ms == 0) {
-		return sock.Send(BHTopicCenterAddress(), head, body);
+		return sock.Send(CenterAddr(), head, body);
 	} else {
-		MsgI reply;
+		MsgI reply(shm());
 		DEFER1(reply.Release(););
 		BHMsgHead reply_head;
-		bool r = sock.SendAndRecv(BHTopicCenterAddress(), head, body, reply, reply_head, timeout_ms);
+		bool r = sock.SendAndRecv(CenterAddr(), head, body, reply, reply_head, timeout_ms);
 		r = r && reply_head.type() == kMsgTypeCommonReply;
 		r = r && reply.ParseBody(reply_body);
 		return r;
@@ -399,10 +416,11 @@
 	}
 	BHMsgHead head;
 	std::string body;
+	FibUSleeper sleeper(1000 * 10);
 	auto end_time = steady_clock::now() + milliseconds(timeout_ms);
 	while (!server_buffer_->Read(head, body)) {
 		if (steady_clock::now() < end_time) {
-			robust::QuickSleep();
+			sleeper.Sleep();
 		} else {
 			return false;
 		}
@@ -479,9 +497,10 @@
 
 	out_msg_id = msg_id;
 
-	auto SendTo = [this, msg_id](const MQInfo &remote, const MsgRequestTopic &req, const RequestResultCB &cb) {
+	auto SendTo = [this, remote_addr, msg_id](const MQInfo &remote, const MsgRequestTopic &req, const RequestResultCB &cb) {
 		auto &sock = SockClient();
 		BHMsgHead head(InitMsgHead(GetType(req), proc_id(), ssn(), msg_id));
+		*head.mutable_dest() = remote_addr;
 		AddRoute(head, sock);
 		head.set_topic(req.topic());
 
@@ -501,8 +520,12 @@
 	};
 
 	try {
-		BHAddress addr;
-		return (ClientQueryRPCTopic(req.topic(), addr, 3000)) && SendTo(MQInfo{addr.mq_id(), addr.abs_addr()}, req, cb);
+		if (remote_addr.ip().empty()) {
+			BHAddress addr;
+			return (ClientQueryRPCTopic(req.topic(), addr, 3000)) && SendTo(MQInfo{addr.mq_id(), addr.abs_addr()}, req, cb);
+		} else {
+			return SendTo(CenterAddr(), req, cb);
+		}
 	} catch (...) {
 		SetLastError(eError, "internal error.");
 		return false;
@@ -518,26 +541,36 @@
 
 	try {
 		auto &sock = SockClient();
-
-		BHAddress addr;
-		if (ClientQueryRPCTopic(request.topic(), addr, timeout_ms)) {
-			LOG_TRACE() << "node: " << SockNode().id() << ", topic dest: " << addr.mq_id();
-			BHMsgHead head(InitMsgHead(GetType(request), proc_id(), ssn()));
-			AddRoute(head, sock);
-			head.set_topic(request.topic());
-
-			MsgI reply_msg;
-			DEFER1(reply_msg.Release(););
-			BHMsgHead reply_head;
-
-			if (sock.SendAndRecv({addr.mq_id(), addr.abs_addr()}, head, request, reply_msg, reply_head, timeout_ms) &&
-			    reply_head.type() == kMsgTypeRequestTopicReply &&
-			    reply_msg.ParseBody(out_reply)) {
-				reply_head.mutable_proc_id()->swap(out_proc_id);
-				return true;
+		MQInfo dest;
+		if (!remote_addr.ip().empty()) {
+			dest = CenterAddr();
+		} else {
+			BHAddress addr;
+			if (ClientQueryRPCTopic(request.topic(), addr, timeout_ms)) {
+				dest.offset_ = addr.abs_addr();
+				dest.id_ = addr.mq_id();
+			} else {
+				return false;
 			}
 		}
-	} catch (...) {
+
+		BHMsgHead head(InitMsgHead(GetType(request), proc_id(), ssn()));
+		*head.mutable_dest() = remote_addr;
+		AddRoute(head, sock);
+		head.set_topic(request.topic());
+
+		MsgI reply_msg(shm());
+		DEFER1(reply_msg.Release(););
+		BHMsgHead reply_head;
+
+		if (sock.SendAndRecv(dest, head, request, reply_msg, reply_head, timeout_ms) &&
+		    reply_head.type() == kMsgTypeRequestTopicReply &&
+		    reply_msg.ParseBody(out_reply)) {
+			reply_head.mutable_proc_id()->swap(out_proc_id);
+			return true;
+		}
+	} catch (std::exception &e) {
+		LOG_ERROR() << __func__ << " exception: " << e.what();
 		SetLastError(eError, __func__ + std::string(" internal errer."));
 	}
 	return false;
@@ -595,15 +628,16 @@
 		auto &sock = SockPub();
 		BHMsgHead head(InitMsgHead(GetType(pub), proc_id(), ssn()));
 		AddRoute(head, sock);
+		head.set_topic(pub.topic());
 
 		if (timeout_ms == 0) {
-			return sock.Send(BHTopicBusAddress(), head, pub);
+			return sock.Send(BusAddr(), head, pub);
 		} else {
-			MsgI reply;
+			MsgI reply(shm());
 			DEFER1(reply.Release(););
 			BHMsgHead reply_head;
 			MsgCommonReply reply_body;
-			return sock.SendAndRecv(BHTopicBusAddress(), head, pub, reply, reply_head, timeout_ms) &&
+			return sock.SendAndRecv(BusAddr(), head, pub, reply, reply_head, timeout_ms) &&
 			       reply_head.type() == kMsgTypeCommonReply &&
 			       reply.ParseBody(reply_body) &&
 			       IsSuccess(reply_body.errmsg().errcode());
@@ -615,7 +649,7 @@
 
 // subscribe
 
-bool TopicNode::Subscribe(MsgTopicList &topics, MsgCommonReply &reply_body, const int timeout_ms)
+bool TopicNode::DoSubscribe(MsgTopicList &topics, const bool net, MsgCommonReply &reply_body, const int timeout_ms)
 {
 	if (!IsOnline()) {
 		SetLastError(eNotRegistered, kErrMsgNotRegistered);
@@ -625,22 +659,22 @@
 	try {
 		auto &sock = SockSub();
 		MsgSubscribe sub;
+		sub.set_network(net);
 		sub.mutable_topics()->Swap(&topics);
 
 		BHMsgHead head(InitMsgHead(GetType(sub), proc_id(), ssn()));
 		AddRoute(head, sock);
 		if (timeout_ms == 0) {
-			return sock.Send(BHTopicBusAddress(), head, sub);
+			return sock.Send(BusAddr(), head, sub);
 		} else {
-			MsgI reply;
+			MsgI reply(shm());
 			DEFER1(reply.Release(););
 			BHMsgHead reply_head;
-			return sock.SendAndRecv(BHTopicBusAddress(), head, sub, reply, reply_head, timeout_ms) &&
+			return sock.SendAndRecv(BusAddr(), head, sub, reply, reply_head, timeout_ms) &&
 			       reply_head.type() == kMsgTypeCommonReply &&
 			       reply.ParseBody(reply_body) &&
 			       IsSuccess(reply_body.errmsg().errcode());
 		}
-		// TODO wait for result?
 	} catch (...) {
 		return false;
 	}
@@ -677,20 +711,21 @@
 
 	BHMsgHead head;
 	std::string body;
+	FibUSleeper sleeper(1000 * 10);
 	auto end_time = steady_clock::now() + milliseconds(timeout_ms);
 	while (!sub_buffer_->Read(head, body)) {
 		if (steady_clock::now() < end_time) {
-			robust::QuickSleep();
+			sleeper.Sleep();
 		} else {
 			return false;
 		}
 	}
-	//TODO error msg.
 	if (head.type() == kMsgTypePublish) {
 		if (pub.ParseFromString(body)) {
 			head.mutable_proc_id()->swap(proc_id);
 			return true;
 		}
 	}
+	SetLastError(eError, "invalid subcribe msg received.");
 	return false;
 }
\ No newline at end of file

--
Gitblit v1.8.0