From 2988d18a77dcdc58f6e7f1c16ffe5f62900bb15b Mon Sep 17 00:00:00 2001
From: zhangmeng <775834166@qq.com>
Date: 星期三, 14 十二月 2022 17:20:26 +0800
Subject: [PATCH] fixed memory leak
---
src/bn_api.cpp | 15 ++++++++++-----
1 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/src/bn_api.cpp b/src/bn_api.cpp
index 39866a8..3ecf961 100644
--- a/src/bn_api.cpp
+++ b/src/bn_api.cpp
@@ -116,8 +116,10 @@
// printf("======>> BHRegisterTopics topic %s\n", mtl.topic_list(i).c_str());
mtl2.add_topic_list(mtl.topic_list(i));
}
+ std::move(mtl);
string msg(mtl2.SerializeAsString());
+ std::move(mtl2);
auto ret = simple_request(url, msg.data(), msg.size(), reply, reply_len, timeout_ms);
// printf("======>> BHRegisterTopics return value %d msg size %lu\n", ret, msg.size());
@@ -133,7 +135,7 @@
{
if (!topic || topic_len <= 0) return false;
- auto url(get_url(URLQueryTopic));
+ const auto& url = get_url(URLQueryTopic);
if (url.empty()) {
set_last_error("BHQueryTopicAddress url empty");
return false;
@@ -162,7 +164,7 @@
{
// if (!query || query_len <= 0) return false;
- auto url(get_url(URLQueryProcs));
+ const auto& url = get_url(URLQueryProcs);
if (url.empty()) {
set_last_error("BHQueryProcs url empty");
return false;
@@ -204,6 +206,8 @@
newPub.set_data(string{(const char*)msgpub, (const size_t)msgpub_len});
string msg(newPub.SerializeAsString());
+ std::move(newPub);
+
if (pub.topic().empty()) {
set_last_error("BHPublish topic empty");
return false;
@@ -231,6 +235,7 @@
// printf("BHSubscribeTopics %s\n", t.c_str());
subscribe_topic(t);
}
+ std::move(mtl);
auto ret = simple_request(url, topics, topics_len, reply, reply_len, timeout_ms);
if (!ret){
@@ -307,8 +312,10 @@
bhome_msg::MsgQueryTopic msg;
msg.set_topic(req.topic());
+ std::move(req);
string s(msg.SerializeAsString());
+ std::move(msg);
void* reply2;
int reply_len2;
@@ -316,7 +323,6 @@
int ret = BHQueryTopicAddress(remote.c_str(), remote.length(), s.data(), s.size(),
&reply2, &reply_len2, timeout_ms);
if (!ret) return false;
-
bhome_msg::MsgQueryTopicReply mr;
if (!mr.ParseFromArray(reply2, reply_len2)){
@@ -329,9 +335,8 @@
}
auto& node_addr = mr.node_address(0);
- auto& procid = node_addr.proc_id();
+ *proc_id = node_addr.proc_id();
- *proc_id = procid;
return true;
}
--
Gitblit v1.8.0