From d90b3c3779d9c6bd2884540621d107e4ac10e930 Mon Sep 17 00:00:00 2001
From: zhangmeng <775834166@qq.com>
Date: 星期四, 04 八月 2022 09:10:58 +0800
Subject: [PATCH] tcp remote reduce timeout in readrequest

---
 src/bn_api.cpp |   59 ++++++++++++++++++++++++++++++++++++++++++++++-------------
 1 files changed, 46 insertions(+), 13 deletions(-)

diff --git a/src/bn_api.cpp b/src/bn_api.cpp
index 91ce3b0..39866a8 100644
--- a/src/bn_api.cpp
+++ b/src/bn_api.cpp
@@ -97,6 +97,10 @@
     if (!topics || topics_len <= 0) return false;
 
     const auto& url = get_url(URLRegTopic);
+    if (url.empty()) {
+        set_last_error("BHRegisterTopics url empty");
+        return false;
+    }
 
     bhome_msg::MsgTopicList mtl;
     if (!mtl.ParseFromArray(topics, topics_len)){
@@ -130,7 +134,10 @@
     if (!topic || topic_len <= 0) return false;
 
     auto url(get_url(URLQueryTopic));
-
+    if (url.empty()) {
+        set_last_error("BHQueryTopicAddress url empty");
+        return false;
+    }
     // if (remote && remote_len > 0){
     //     BHAddress addr;
     //     if (addr.ParseFromArray(remote, remote_len)){
@@ -156,6 +163,10 @@
     // if (!query || query_len <= 0) return false;
 
     auto url(get_url(URLQueryProcs));
+    if (url.empty()) {
+        set_last_error("BHQueryProcs url empty");
+        return false;
+    }
 
     // if (remote && remote_len > 0){
     //     BHAddress addr;
@@ -193,6 +204,10 @@
     newPub.set_data(string{(const char*)msgpub, (const size_t)msgpub_len});
 
     string msg(newPub.SerializeAsString());
+    if (pub.topic().empty()) {
+        set_last_error("BHPublish topic empty");
+        return false;
+    }
     auto ret = publish(pub.topic(), msg.data(), msg.size());
     if (ret == 0) return false;
     return true;
@@ -226,12 +241,23 @@
 // 璁㈤槄
 int BHSubscribeTopics(const void *topics, const int topics_len, void **reply, int *reply_len, const int timeout_ms)
 {
-    return sub(get_url(URLSubLocal), topics, topics_len, reply, reply_len, timeout_ms);
+    const auto& url = get_url(URLSubLocal);
+    if (url.empty()) {
+        set_last_error("BHSubscribeTopics url empty");
+        return false;
+    }
+    return sub(url, topics, topics_len, reply, reply_len, timeout_ms);
 }
 // 璁㈤槄缃戠粶,涓嶅疄鐜�
 int BHSubscribeNetTopics(const void *topics, const int topics_len, void **reply, int *reply_len, const int timeout_ms)
 {
-    return sub(get_url(URLSubNet), topics, topics_len, reply, reply_len, timeout_ms);
+    const auto& url = get_url(URLSubNet);
+    if (url.empty()) {
+        set_last_error("BHSubscribeNetTopics url empty");
+        return false;
+    }
+
+    return sub(url, topics, topics_len, reply, reply_len, timeout_ms);
 }
 
 // 璇诲彇璁㈤槄娑堟伅,proc_id鏆傛椂娌$敤锛岃繑鍥瀎ake msg
@@ -325,19 +351,24 @@
     string url{};
     // BHQueryTopicAddress鑾峰彇proc_id
     string procid{};
-    if (get_proc_id_from_MsgRequestTopic(request, request_len, timeout_ms, &procid)){
-        // PRNTVITAG("get_proc_id_from_MsgRequestTopic failed");
-        // return false;
-        url = "ipc:///tmp/" + procid;
-    }
+
     if (remote && remote_len > 0){
         BHAddress addr;
         if (addr.ParseFromArray(remote, remote_len)){
             if (!addr.ip().empty() && addr.port() > 0){
                 url = "tcp://" + addr.ip() + ":" + to_string(addr.port());
-                printf("======>> BHRequest use remote address %s\n", url.c_str());
+                // printf("======>> BHRequest use remote address %s\n", url.c_str());
             }
         }
+    } else if (get_proc_id_from_MsgRequestTopic(request, request_len, timeout_ms, &procid)){
+        // PRNTVITAG("get_proc_id_from_MsgRequestTopic failed");
+        // return false;
+        url = "ipc:///tmp/" + procid;
+    }
+
+    if (url.empty()) {
+        set_last_error("BHRequest url empty");
+        return false;
     }
 
     int rc = request2(url, request, request_len, reply, reply_len, timeout_ms);
@@ -357,11 +388,13 @@
 {
     string msg;
     auto ret = read_request(src, &msg, timeout_ms);
-    if (ret != 0) return false;
+    if (ret < 0) return false;
 
-    string procid{};
-    if (get_proc_id_from_MsgRequestTopic(msg.data(), msg.size(), timeout_ms, &procid)){
-        copy_memory(proc_id, proc_id_len, procid.data(), procid.size());
+    if (ret == REPLY_IPC){
+        string procid{};
+        if (get_proc_id_from_MsgRequestTopic(msg.data(), msg.size(), timeout_ms, &procid)){
+            copy_memory(proc_id, proc_id_len, procid.data(), procid.size());
+        }
     }
 
     copy_memory(request, request_len, msg.data(), msg.size());

--
Gitblit v1.8.0